v2 and jsapi4: src, test pages, docs site #282
Conversation
- README - esriLoader (and unit tests) - MapView, SceneView, and HomeButton src
- feature layer, scene view, and vector tile test pages
- extrude polygon, webscene-slides test pages
- home button, scene toggle elevation test pages - esri-home-button directive now takes a "view-ui-position" argument
- 8 test pages to be compliant with jsapi 4.0 - test pages README
- e2e spec test pages - misc. meta tag for popups test page
- main.css: bringing back button styles that were inadvertently removed
- appConfig TOC object - 8 examples, and 3 test pages for consistency - finally resolves #211 issue regarding popups at jsapi 4
- appConfig TOC object - finished updating examples, and some test pages for consistency
- patterns docs pages - updated and included missing deferred-map test page (!)
|
nice work! Changes look good to me, but it's a lot to review, so I brushed over a lot. Also, when I tried to run locally, mixed content errors prevent a few of the examples from running b/c Chrome hates developers, and I haven't had time to set up the cert for my new machine, yet. It's mostly the examples under the 3D section, if they run for you, then that's good. Also, I wasn't able to run the e2e tests b/c Selenium hates America and I need to get chromedriver or something installed on my new machine. So, if the site and tests are running for you, I'd say merge it. Both of the issues I'm having w/ my new machine show that we need better dev instructions, package.json devDependencies, or both, but that's an issue for another day. |
jwasilgeo
changed the title
|
Tom, thanks for looking over this. Do you have any other details on the mixed content issues? I just saw a mixed content error in the console for the "WebScene Slides" example page, but it also exists in the same way for the Esri JSAPI example page. I don't see other examples being obviously affected or blocked when running locally (Chrome 50, Windows 7). |
- updated v2 README quick start code (JSAPI v4 and Angular v1.5.5) - updated v2 README dependencies table - added more info to CHANGELOG
|
So, I can run through all the example pages (now on newly merged master) in FireFox and Safari w/ no problems. However, in Chrome, many things are broken, and I think it's b/c Chrome doesn't like my local cert and blocks a lot of the functionality (pretty much nothing happens when I click on any buttons or checkboxes). |
|
Weird, sorry you are experiencing that. Right now crossing my fingers it is just your new dev environment. Didn't see that on (now deleted) my own temp fork's gh-pages with the latest stuff either. I'll continue to keep an eye out. |
@tomwayson please review.
This is the second PR as part of a larger effort to get this repo ready with JSAPI 4.0 release. Please reference #278 for a full TO DO list. This PR's branch is different than, but continues from, the branch in PR #281. This starts at fc849ee.
Here you can expect to find updates to:
ng-clickin the home button directive's template (instead oflinkfunc)