fix scan_from_url to clone to a dir name consists of the full url

Gal Ben David · Gal Ben David · commit 8339b66ed818 · 2021-03-26T15:21:57.000+03:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "pyrepscan"
-version = "0.9.0"
+version = "0.9.1"
 authors = ["Gal Ben David <gal@intsights.com>"]
 edition = "2018"
 description = "A Git Repository Secrets Scanner written in Rust"
@@ -41,6 +41,7 @@ num_cpus = "1"
 parking_lot = "0.11"
 crossbeam = "0.8"
 crossbeam-utils = "0.8"
+percent-encoding = "2"
 
 [dependencies.git2]
 version = "0.13"
diff --git a/pyproject.toml b/pyproject.toml
@@ -14,7 +14,7 @@ strip = true
 
 [tool.poetry]
 name = "pyrepscan"
-version = "0.9.0"
+version = "0.9.1"
 authors = ["Gal Ben David <gal@intsights.com>"]
 description = "A Git Repository Secrets Scanner written in Rust"
 readme = "README.md"
diff --git a/src/lib.rs b/src/lib.rs
@@ -2,6 +2,7 @@ mod git_repository_scanner;
 mod rules_manager;
 
 use parking_lot::Mutex;
+use percent_encoding::{utf8_percent_encode, NON_ALPHANUMERIC};
 use pyo3::exceptions;
 use pyo3::prelude::*;
 use pyo3::types::PyBytes;
@@ -242,7 +243,7 @@ impl GitRepositoryScanner {
         from_timestamp: Option<i64>,
     ) -> PyResult<Py<PyAny>> {
         let mut repository_full_path = PathBuf::from(repository_path);
-        repository_full_path.push(url.split('/').last().unwrap_or(""));
+        repository_full_path.push(utf8_percent_encode(url, NON_ALPHANUMERIC).to_string());
 
         let mut builder = git2::build::RepoBuilder::new();
         builder.bare(true);
@@ -253,7 +254,7 @@ impl GitRepositoryScanner {
         let matches = Arc::new(Mutex::new(Vec::<HashMap<&str, String>>::with_capacity(10000)));
         match git_repository_scanner::scan_repository(
             &py,
-            repository_path,
+            &repository_full_path.to_string_lossy(),
             branch_glob_pattern.unwrap_or("*"),
             from_timestamp.unwrap_or(0),
             &self.rules_manager,
