Skip to content

Undefined dataset on language select in Settings-Screen #176

Open
@JulianSchoenbaechler

Description

@JulianSchoenbaechler

When clicking on the arrow-icon [data-select="set-language"] of the language selection dropdown the action will break with:

Uncaught TypeError: t.dataset is undefined

The erroneous code is this piece right here:

// Fix for select labels
this.engine.on ('click', '[data-select]', () => {
	const e = document.createEvent ('MouseEvents');
	e.initMouseEvent ('mousedown');
	this.engine.element ().find (`[data-action='${this.dataset.select}']`).first ().dispatchEvent (e);
});

I'm guessing that the this inside the arrow function does not refer to the actual HTMLElement of the icon.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions