Skip to content

feature: add base16 support #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 5, 2024
Merged

feature: add base16 support #389

merged 10 commits into from
Oct 5, 2024

Conversation

bloxx12
Copy link
Contributor

@bloxx12 bloxx12 commented Sep 29, 2024 •
edited
Loading

Description

This PR aims to provide basic base16 support. This is more of a draft and by far not finished, there are several things to be improved still. base16 theming is working by now, what is to be fixed/redone:

  • Loading of plugins like base16-nvim, at the moment theme.name = "base16-nvim" enables theming via base16, it'd be nice to just be able to use theme.name = "base16".
  • definition of the 16 hexadecimal colors
  • documentation updates
  • improve code quality to a point where Dianimo does not get angry upon seeing it

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

Please try to check at least a majority of the checklist before opening your pull request. Exceptions to this will be reviewed on a case by case basis.

  • My code follows the style and contributing guidelines of this project.
  • I ran Alejandra to format my code (nix fmt).
  • I have performed a self-review of my own code and tested it.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • This change requires a documentation update.
  • I have updated the documentation accordingly.

@bloxx12 bloxx12 requested a review from NotAShelf as a code owner September 29, 2024 21:32
@C4E5G3
Copy link

C4E5G3 commented Oct 3, 2024

Hi Bloxx,

Is it Raf who has to review the additions?

@bloxx12
Copy link
Contributor Author

bloxx12 commented Oct 3, 2024

Hey there, there is still stuff to be done so this will not be merged yet, I may end up redoing the whole theming module if I find the time, since it's kind of hard to implement base16 cleanly in the current one. I'm still working on this, stay tuned till the weekend! :)

@bloxx12 bloxx12 marked this pull request as draft October 3, 2024 12:41
@diniamo
Copy link
Contributor

diniamo commented Oct 4, 2024

Please reopen this PR to target the v0.7 branch.

@NotAShelf NotAShelf changed the base branch from main to v0.7 October 4, 2024 14:00
@NotAShelf
Copy link
Owner

I rebased the PR against 0.7. If there are any merge conflicts, GH UI should point them out.

@diniamo
Copy link
Contributor

diniamo commented Oct 4, 2024

Didn't know that was possible

@bloxx12
modules: add base16 Theming support
e80dedd 
theme/theme.nix: fix formatting

supported-themes.nix: formatting

clean up base16-colors.nix

theme: fix plugin setup, change base16 flake input
diniamo
diniamo suggested changes Oct 5, 2024
View reviewed changes
bloxx12 added 2 commits October 5, 2024 13:01
@bloxx12
lib/types: rename custom.nix to types.nix, mov theme.nix into types.nix
5db7e2a
@bloxx12
plugins/theme: apply requested changes
49ec0ad 
types/types.nix: remove unneeded inherit

theme/theme.nix: remove commented inherit
@bloxx12 bloxx12 marked this pull request as ready for review October 5, 2024 11:06
@bloxx12 @diniamo
theme/theme.nix: fix up base16 helper func
423ed4d 
Co-authored-by: diniamo <55629891+diniamo@users.noreply.github.com>
@diniamo
Copy link
Contributor

diniamo commented Oct 5, 2024

You could include Closes #270 in the PR description

@NotAShelf NotAShelf added the enhancement New feature or request label Oct 5, 2024
@NotAShelf NotAShelf linked an issue Oct 5, 2024 that may be closed by this pull request
Add support for base16 theming. #270
Closed
1 task
NotAShelf
NotAShelf requested changes Oct 5, 2024
View reviewed changes
@NotAShelf NotAShelf self-requested a review October 5, 2024 13:15
NotAShelf
NotAShelf requested changes Oct 5, 2024
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noticed, you're missing a changelog entry in /docs/release-notes/0.7.md If you add the entry, I think we'll be golden.

@NotAShelf NotAShelf merged commit bdf777d into NotAShelf:v0.7 Oct 5, 2024
7 checks passed
@NotAShelf NotAShelf mentioned this pull request Oct 5, 2024
Merged
@C4E5G3
Copy link

C4E5G3 commented Oct 8, 2024

Okay, but base16 is not yet in the supported themes

@NotAShelf
Copy link
Owner

NotAShelf commented Oct 8, 2024 •
edited
Loading

Base16 support is officially in the v0.7 branch, which is not yet merged to stable (main). You can test v0.7 by pinning it as your input, or you can wait until 0.7 is merged into main.

@C4E5G3
Copy link

C4E5G3 commented Oct 15, 2024

I tried pinning v.7 but this change


• Removed input 'nvf/plugin-cmp-luasnip'
• Added input 'nvf/plugin-cmp-vsnip':

means my vim.autocomplete settings no longer work:


  error: The option `vim.autocomplete.sources' does not exist. Definition values:
┃        - In `<unknown-file>':
┃            {
┃              buffer = "[Buffer]";
┃              nvim_lsp = "[LSP]";
┃              path = "[Path]";
┃            }

@NotAShelf
Copy link
Owner

The autocompletion module was reworked in #404

Please refer to the changelog entry for how to migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diniamo diniamo diniamo approved these changes

@NotAShelf NotAShelf NotAShelf approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for base16 theming.
4 participants
@bloxx12 @C4E5G3 @diniamo @NotAShelf