Fix issue from static analysis

j-troc · wiertel · commit b865fbf804fb · 2018-10-16T16:04:05.000+02:00
diff --git a/DependencyService/Tizen/TextToSpeechImplementation.cs b/DependencyService/Tizen/TextToSpeechImplementation.cs
@@ -28,15 +28,16 @@ public Task Prepare(TtsClient speaker)
 
         public async void Speak(string text)
         {
-            TtsClient speaker = new TtsClient();
-
-            if (speaker.CurrentState == State.Created)
-                await Prepare(speaker);
-
-            if (speaker.CurrentState == State.Ready)
+            using (TtsClient speaker = new TtsClient())
             {
-                speaker.AddText(text, speaker.DefaultVoice.Language, (int)speaker.DefaultVoice.VoiceType, speaker.GetSpeedRange().Normal);
-                speaker.Play();
+                if (speaker.CurrentState == State.Created)
+                    await Prepare(speaker);
+
+                if (speaker.CurrentState == State.Ready)
+                {
+                    speaker.AddText(text, speaker.DefaultVoice.Language, (int)speaker.DefaultVoice.VoiceType, speaker.GetSpeedRange().Normal);
+                    speaker.Play();
+                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,16 @@ public Task Prepare(TtsClient speaker)`
`28`	`28`
`29`	`29`	`public async void Speak(string text)`
`30`	`30`	`{`
`31`		`- TtsClient speaker = new TtsClient();`
`32`		`-`
`33`		`- if (speaker.CurrentState == State.Created)`
`34`		`- await Prepare(speaker);`
`35`		`-`
`36`		`- if (speaker.CurrentState == State.Ready)`
	`31`	`+ using (TtsClient speaker = new TtsClient())`
`37`	`32`	`{`
`38`		`- speaker.AddText(text, speaker.DefaultVoice.Language, (int)speaker.DefaultVoice.VoiceType, speaker.GetSpeedRange().Normal);`
`39`		`- speaker.Play();`
	`33`	`+ if (speaker.CurrentState == State.Created)`
	`34`	`+ await Prepare(speaker);`
	`35`	`+`
	`36`	`+ if (speaker.CurrentState == State.Ready)`
	`37`	`+ {`
	`38`	`+ speaker.AddText(text, speaker.DefaultVoice.Language, (int)speaker.DefaultVoice.VoiceType, speaker.GetSpeedRange().Normal);`
	`39`	`+ speaker.Play();`
	`40`	`+ }`
`40`	`41`	`}`
`41`	`42`	`}`
`42`	`43`	`}`