Skip to content

Release v0.37 #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 19, 2025
Merged

Release v0.37 #2487

merged 12 commits into from
Mar 19, 2025

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Feb 14, 2025

Collecting breaking changes into a single PR.

mhauru and others added 2 commits February 14, 2025 17:18
* Remove selector stuff from ESS

* Remove selector stuff from MH

* Remove selector stuff from HMC

* Remove selector stuff from Emcee

* Remove selector stuff from IS

* Add missing getspace methods

* Remove selector stuff for particle methods

* Fix an HMC selector bug

* Code style

* Fix Emcee selector bug

* Fix typo in ESS tests

* Fix some constructor overwrites

* Remove unnecessary tests

* Remove selector stuff from SGHMC

* Remove drop_space and other non-longer-necessary deprecation measures

* Bump minor version 0.37. Add a HISTORY.md entry

* Apply suggestions from code review

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>

* Remove unnecessary type parameters

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>

* Simplify constructors in particle_mcmc.jl

* Remove calls to setgid and updategid

---------

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 97.12644% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.03%. Comparing base (38fa2d6) to head (7aebd1c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/mcmc/mh.jl 90.00% 2 Missing ⚠️
ext/TuringDynamicHMCExt.jl 85.71% 1 Missing ⚠️
src/mcmc/Inference.jl 66.66% 1 Missing ⚠️
src/stdlib/distributions.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
+ Coverage   84.88%   86.03%   +1.14%     
==========================================
  Files          21       21              
  Lines        1628     1454     -174     
==========================================
- Hits         1382     1251     -131     
+ Misses        246      203      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13930147191

Details

  • 169 of 174 (97.13%) changed or added relevant lines in 15 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+9.5%) to 86.039%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ext/TuringDynamicHMCExt.jl 6 7 85.71%
src/mcmc/Inference.jl 2 3 66.67%
src/stdlib/distributions.jl 3 4 75.0%
src/mcmc/mh.jl 18 20 90.0%
Files with Coverage Reduction New Missed Lines %
src/mcmc/mh.jl 1 88.5%
src/mcmc/repeat_sampler.jl 1 88.46%
src/stdlib/distributions.jl 2 61.73%
src/mcmc/Inference.jl 3 81.62%
src/mcmc/gibbs.jl 4 87.43%
Totals Coverage Status
Change from base Build 13903082390: 9.5%
Covered Lines: 1251
Relevant Lines: 1454

💛 - Coveralls

penelopeysm and others added 4 commits February 25, 2025 20:55
* Progress towards compat with DPPL v0.35

* More fixing of DPPL v0.35 stuff

* Fix LogDensityFunction argument order

* More minor bugfixes

* [TEMP] Commit Manifest pointing to DynamicPPL#release-0.35

* remove LogDensityProblemsAD (#2490)

* Remove LogDensityProblemsAD, part 1

* update Optimisation code to not use LogDensityProblemsAD

* Fix field name change

* Don't put chunksize=0

* Remove LogDensityProblemsAD dep

* Improve OptimLogDensity docstring

* Remove unneeded model argument to _optimize

* Fix more tests

* Remove essential/ad from the list of CI groups

* Fix HMC function

* more test fixes (#2491)

* Remove LogDensityProblemsAD, part 1

* update Optimisation code to not use LogDensityProblemsAD

* Fix field name change

* Don't put chunksize=0

* Remove LogDensityProblemsAD dep

* Improve OptimLogDensity docstring

* Remove unneeded model argument to _optimize

* Fix more tests

* Remove essential/ad from the list of CI groups

* Fix HMC function

* More test fixes

* Remove Manifest

* More fixes for DynamicPPL 0.35 (#2494)

* Remove test/dynamicppl/compiler.jl

* Remove old regression tests

* Remove vdemo2

* Fix last test

* Add HISTORY.md entry about DPPL 0.35

* Allow ESS to sample variables with different symbols

* Update a TODO note

---------

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
@mhauru
Copy link
Member Author

mhauru commented Mar 13, 2025

If anyone has PRs they would like to merge into this before releasing v0.37, could you post links here? Just to keep track. @penelopeysm I think you had one or two in mind.

@penelopeysm
Copy link
Member

penelopeysm commented Mar 14, 2025

I just had #2474 in mind. I'm not sure I can get to it tomorrow though, might have to wait until next week.

I think #2503 is an easy fix too (just looks like increasing tolerance on tests), so we could wrap that in.

@yebai
Copy link
Member

yebai commented Mar 14, 2025

#2505

@mhauru mhauru self-assigned this Mar 17, 2025
yebai and others added 2 commits March 17, 2025 13:47
* Remove `Zygote`; fix #2504

* Update test/test_utils/ad_utils.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add HISTORY.md entry about removing support for Zygote

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Markus Hauru <mhauru@turing.ac.uk>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Markus Hauru <markus@mhauru.org>
penelopeysm and others added 2 commits March 18, 2025 17:33
* Regroup exports by package

* Export DynamicPPL.returned and DynamicPPL.prefix

* Stop exporting  @logprob_str and @prob_str

* Remove DynamicPPL module export

* Remove DynamicPPL.LogDensityFunction re-export

* Remove BernoulliLogit, drop support for Distributions < 0.25.77

* Stop blanket re-exporting Libtask and Bijectors

* Manually specify AbstractMCMC exports

* Format

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Remove Bijectors.ordered export

* Re-export LinearAlgebra.I

* Replace Turing.Model -> DynamicPPL.Model

* Format

* Keep exporting LogDensityFunction

* Add note in docs

* Align Turing exports with docs API page

* Fix things like `predict` on docs API page

* Fix a Gibbs test

* Format

* Fix missing Bijectors import

* Update docs/src/api.md

Co-authored-by: Markus Hauru <markus@mhauru.org>

* Update docs/src/api.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Clean up broken docs links, remove unneeded deps

* Format

* Add changelog entry for exports

* Clean up exports in essential/Essential

* Apply suggestions from code review

Co-authored-by: Markus Hauru <markus@mhauru.org>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Markus Hauru <mhauru@turing.ac.uk>
Co-authored-by: Markus Hauru <markus@mhauru.org>
@mhauru mhauru marked this pull request as ready for review March 18, 2025 17:54
@mhauru mhauru requested a review from yebai March 18, 2025 17:55
@mhauru
Copy link
Member Author

mhauru commented Mar 18, 2025

All the three PRs from above are now either in this one or in main. @yebai, could you please have a look at breaking changes in HISTORY.md and give your blessing if you're happy?

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks to all!

@mhauru mhauru merged commit e4cd6a2 into main Mar 19, 2025
47 checks passed
@mhauru mhauru deleted the breaking branch March 19, 2025 11:12
@penelopeysm
Copy link
Member

@gdalle Turing officially uses DI now :)

@gdalle
Copy link

gdalle commented Mar 19, 2025

epic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants