Deprecate IsSoundPrecached (#1172)

naydef · Headline · commit 816c7fc3fd0a · 2020-02-06T10:34:57.000-08:00
Fix #1170
diff --git a/extensions/sdktools/vsound.cpp b/extensions/sdktools/vsound.cpp
@@ -677,11 +677,7 @@ bool InternalPrecacheScriptSound(const char *soundname)
 	for (int wave = 0; wave < waveCount; wave++)
 	{
 		const char* waveName = soundemitterbase->GetWaveName(internal->GetSoundNames()[wave].symbol);
-		// return true even if we precache no new wavs
-		if (!engsound->IsSoundPrecached(waveName))
-		{
-			engsound->PrecacheSound(waveName);
-		}
+		engsound->PrecacheSound(waveName);
 	}
 
 	return true;
@@ -1590,10 +1586,7 @@ static cell_t smn_GetGameSoundParams(IPluginContext *pContext, const cell_t *par
 	pContext->StringToLocal(params[6], params[7], soundParams.soundname);
 
 	// Precache the sound we're returning
-	if (!engsound->IsSoundPrecached(soundParams.soundname))
-	{
-		InternalPrecacheScriptSound(soundname);
-	}
+	InternalPrecacheScriptSound(soundname);
 
 	return true;
 }
diff --git a/plugins/include/halflife.inc b/plugins/include/halflife.inc
@@ -322,7 +322,9 @@ native bool PrecacheSound(const char[] sound, bool preload=false);
  *
  * @param sound         Name of the sound to check.
  * @return              True if precached, false otherwise.
+ * @deprecated          Doesn't work correctly, always returns true.
  */
+#pragma deprecated Doesn't work correctly, always returns true.
 native bool IsSoundPrecached(const char[] sound);
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,9 @@ native bool PrecacheSound(const char[] sound, bool preload=false);`
`322`	`322`	`*`
`323`	`323`	`* @param sound Name of the sound to check.`
`324`	`324`	`* @return True if precached, false otherwise.`
	`325`	`+ * @deprecated Doesn't work correctly, always returns true.`
`325`	`326`	`*/`
	`327`	`+#pragma deprecated Doesn't work correctly, always returns true.`
`326`	`328`	`native bool IsSoundPrecached(const char[] sound);`
`327`	`329`
`328`	`330`	`/**`