Add keyboard shortcut for fullscreen and wrap in logs. #50008
Merged
+50
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
bbovenzi
reviewed
Apr 30, 2025
bbovenzi
reviewed
Apr 30, 2025
bbovenzi
reviewed
Apr 30, 2025
airflow-core/src/airflow/ui/src/pages/Dag/Overview/FailedLogs.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
reviewed
Apr 30, 2025
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
approved these changes
Apr 30, 2025
|
Thanks @bbovenzi , reworded tooltip content as suggested. This is minor feature but still worthy of backport to 3.0.1 release I guess. |
|
Just saw the issue tagged to 3.1.0 milestone in the issue. Please ignore the above message. |
|
No, 3.0.1 is ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Press "f" for fullscreen and "w" for wrap. A tooltip is with 100ms delay added for better discoverability. I have also validated when the user is in the log tab and is editing a dagrun note the keypress "f"/"w" while typing the note are not captured.
Closes #50006