Skip to content

Save systemvm template details for cpvm, ssvm and vr's. #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 4.20
Choose a base branch
from
Open

Save systemvm template details for cpvm, ssvm and vr's. #9721

wants to merge 3 commits into from

Conversation

BartJM
Copy link
Contributor

@BartJM BartJM commented Sep 23, 2024

Description

This PR adds saving systemvm template settings to the user_vm_details table. Allows systemvms to start with details specified in the systemvm template settings.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Change systemvm template settings to add iothreads and io.policy.
Recreate ssvm, cpvm and vr and verified the details are in the db and the vms are running with the change.

Ran on a ubuntu 20.04 manager, 22.04 kvm host testing env and mbx kvm centos8 env.

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Sep 23, 2024

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (bf2cede) to head (e331976).
Report is 342 commits behind head on 4.20.

Files with missing lines Patch % Lines
...in/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java 0.00% 15 Missing ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 0.00% 4 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 3 Missing ⚠️
...va/com/cloud/network/router/NetworkHelperImpl.java 0.00% 3 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 40.00% 3 Missing ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java 0.00% 3 Missing ⚠️
...n/java/com/cloud/capacity/CapacityManagerImpl.java 0.00% 2 Missing ⚠️
...om/cloud/network/element/VirtualRouterElement.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##               4.20    #9721     +/-   ##
===========================================
  Coverage     15.78%   15.78%             
- Complexity    12550    12552      +2     
===========================================
  Files          5625     5625             
  Lines        491958   491968     +10     
  Branches      60504    61727   +1223     
===========================================
+ Hits          77663    77673     +10     
+ Misses       405836   405834      -2     
- Partials       8459     8461      +2
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 16.60% <5.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache
weizhouapache approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

not tested yet

@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11190

@BartJM BartJM force-pushed the systemvm-save-template-details branch from 9d3550d to e331976 Compare September 27, 2024 09:30
DaanHoogland
DaanHoogland approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks @BartJM CLGTM

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@BartJM
Copy link
Contributor Author

BartJM commented Sep 27, 2024

With the new changes also tested the following on mbx centos8 kvm for user vms. All changes were reflected in the database as expected.

  • Create a vm with ssh key,
  • Create password enabled vm with ssh key.
  • Reset ssh key and password.
  • Set iothreads enabled and io.policy to storage_specific.
  • Create a vm with custom offering, change the custom values and change offering to fixed
  • Change vm with fixed offering to custom offering

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11217

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11565)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 66133 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t11565-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_create_iso_with_checksum_md5 Error 66.48 test_iso.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_disable_oobm_ha_state_ineligible Error 288.31 test_hostha_kvm.py
test_hostha_configure_default_driver Error 77.00 test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled Error 87.68 test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected Error 156.97 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 151.03 test_hostha_kvm.py
test_hostha_kvm_host_degraded Error 76.92 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 35.70 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 34.50 test_hostha_kvm.py
test_remove_ha_provider_not_possible Error 37.59 test_hostha_kvm.py

@DaanHoogland
Copy link
Contributor

I cannot relate any of the errors to the code (yet) trying insanity first.

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11243

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12465

@Pearl1594 Pearl1594 changed the base branch from main to 4.20 February 14, 2025 15:56
@Pearl1594
Copy link
Contributor

I've targeted this against 4.20.

@Pearl1594
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12468

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@apache apache deleted a comment from blueorangutan Feb 18, 2025
@apache apache deleted a comment from blueorangutan Feb 18, 2025
@apache apache deleted a comment from blueorangutan Feb 18, 2025
@Pearl1594
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12465)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 55625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t12465-kvm-ubuntu22.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_11_isolated_network_with_dynamic_routed_mode Error 1.34 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.43 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.43 test_ipv4_routing.py
test_oobm_multiple_mgmt_server_ownership Failure 31.89 test_outofbandmanagement.py
test_06_purge_expunged_vm_background_task Failure 385.67 test_purge_expunged_vms.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12464)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59355 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t12464-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.28 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.48 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.48 test_ipv4_routing.py
test_06_purge_expunged_vm_background_task Failure 393.56 test_purge_expunged_vms.py
test_01_redundant_vpc_site2site_vpn Failure 481.92 test_vpc_vpn.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12466)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63561 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t12466-vmware-70u3.zip
Smoke tests completed. 129 look OK, 12 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 361.73 test_events_resource.py
test_04_deploy_vm_with_extraconfig_throws_exception_vmware Error 4.57 test_deploy_vm_extra_config_data.py
test_11_isolated_network_with_dynamic_routed_mode Error 1.32 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.42 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.42 test_ipv4_routing.py
test_deploy_more_vms_than_limit_allows Error 139.46 test_deploy_vms_in_parallel.py
test_04_list_domains_level_filter Failure 0.04 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_05_list_volumes_isrecursive Failure 0.04 test_list_volumes.py
test_07_list_volumes_listall Failure 0.04 test_list_volumes.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 117.21 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 155.30 test_network.py
test_06_purge_expunged_vm_background_task Failure 396.96 test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering Error 60.18 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 52.89 test_restore_vm.py
test_14_destroy_vm_delete_protection Error 7.62 test_vm_life_cycle.py
test_02_restore_vm_strict_tags_failure Error 58.40 test_vm_strict_host_tags.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12467)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 74470 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t12467-xcpng82.zip
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Failure 164.19 test_cluster_drs.py
test_02_balanced_drs_algorithm Failure 189.28 test_cluster_drs.py
test_11_isolated_network_with_dynamic_routed_mode Error 1.24 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.75 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.75 test_ipv4_routing.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 10.49 test_network.py
test_01_non_strict_host_anti_affinity Error 232.93 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 117.12 test_nonstrict_affinity_group.py
test_06_purge_expunged_vm_background_task Failure 407.70 test_purge_expunged_vms.py
test_create_pvlan_network Error 0.09 test_pvlan.py
test_02_create_volume Error 3.21 test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change Failure 73.70 test_scale_vm.py

@Pearl1594
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12589

@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@Pearl1594
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12732)

@shwstppr
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13071

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wido wido wido approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees
No one assigned
Labels
component:compute component:networking component:orchestration component:secondary-storage component:ssvm status:has-conflicts status:needs-testing type:improvement
Projects
ACS 4.20.1
Status: In Progress
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.
8 participants
@BartJM @weizhouapache @blueorangutan @DaanHoogland @shwstppr @Pearl1594 @wido @vladimirpetrov