Skip to content

Commit c84e110

Browse files
[MASSEMBLY-1019] Maven 3.6.3 as minimum requirements
1 parent 136fe36 commit c84e110

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

pom.xml

+14-8
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ under the License.
2828
</parent>
2929

3030
<artifactId>maven-assembly-plugin</artifactId>
31-
<version>3.6.1-SNAPSHOT</version>
31+
<version>3.7.0-SNAPSHOT</version>
3232
<packaging>maven-plugin</packaging>
3333

3434
<name>Apache Maven Assembly Plugin</name>
@@ -73,14 +73,14 @@ under the License.
7373

7474
<javaVersion>8</javaVersion>
7575
<mdoVersion>2.2.0</mdoVersion>
76-
<mavenVersion>3.2.5</mavenVersion>
76+
<mavenVersion>3.6.3</mavenVersion>
7777
<slf4jVersion>1.7.5</slf4jVersion>
7878
<mavenFilteringVersion>3.3.1</mavenFilteringVersion>
7979
<mavenArchiverVersion>3.6.1</mavenArchiverVersion>
8080
<commonsIoVersion>2.15.1</commonsIoVersion>
8181

8282
<testOutputToFile>true</testOutputToFile>
83-
<project.build.outputTimestamp>2023-05-11T20:36:09Z</project.build.outputTimestamp>
83+
<project.build.outputTimestamp>2024-02-17T22:53:24Z</project.build.outputTimestamp>
8484
</properties>
8585

8686
<dependencies>
@@ -109,11 +109,12 @@ under the License.
109109
<scope>provided</scope>
110110
</dependency>
111111
<dependency>
112-
<groupId>org.eclipse.aether</groupId>
113-
<artifactId>aether-util</artifactId>
114-
<!-- the same version as in Maven 3.2.5 -->
115-
<version>1.0.0.v20140518</version>
112+
<groupId>org.apache.maven.resolver</groupId>
113+
<artifactId>maven-resolver-util</artifactId>
114+
<!-- the same version as in Maven 3.6.3 -->
115+
<version>1.4.1</version>
116116
</dependency>
117+
117118
<dependency>
118119
<groupId>org.slf4j</groupId>
119120
<artifactId>slf4j-api</artifactId>
@@ -296,7 +297,12 @@ under the License.
296297
<configuration>
297298
<requirementsHistories>
298299
<requirementsHistory>
299-
<version>from 3.4.0</version>
300+
<version>from 3.7.0</version>
301+
<maven>3.6.3</maven>
302+
<jdk>8</jdk>
303+
</requirementsHistory>
304+
<requirementsHistory>
305+
<version>from 3.4.0 to 3.6.0</version>
300306
<maven>3.2.5</maven>
301307
<jdk>8</jdk>
302308
</requirementsHistory>

src/test/java/org/apache/maven/plugins/assembly/archive/task/AddDependencySetsTaskTest.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.apache.maven.plugins.assembly.format.AssemblyFormattingException;
3838
import org.apache.maven.plugins.assembly.model.DependencySet;
3939
import org.apache.maven.plugins.assembly.model.UnpackOptions;
40+
import org.apache.maven.project.DefaultProjectBuildingRequest;
4041
import org.apache.maven.project.MavenProject;
4142
import org.apache.maven.project.ProjectBuilder;
4243
import org.apache.maven.project.ProjectBuildingException;
@@ -123,7 +124,7 @@ public void testAddDependencySet_ShouldInterpolateDefaultOutputFileNameMapping()
123124
.thenReturn(pbr);
124125

125126
final MavenSession session = mock(MavenSession.class);
126-
when(session.getProjectBuildingRequest()).thenReturn(mock(ProjectBuildingRequest.class));
127+
when(session.getProjectBuildingRequest()).thenReturn(new DefaultProjectBuildingRequest());
127128
when(session.getUserProperties()).thenReturn(new Properties());
128129
when(session.getSystemProperties()).thenReturn(new Properties());
129130

@@ -212,7 +213,7 @@ public void testAddDependencySet_ShouldNotAddDependenciesWhenProjectIsStubbed()
212213
.thenThrow(pbe);
213214

214215
final MavenSession session = mock(MavenSession.class);
215-
when(session.getProjectBuildingRequest()).thenReturn(mock(ProjectBuildingRequest.class));
216+
when(session.getProjectBuildingRequest()).thenReturn(new DefaultProjectBuildingRequest());
216217
when(session.getUserProperties()).thenReturn(new Properties());
217218
when(session.getSystemProperties()).thenReturn(new Properties());
218219

@@ -272,7 +273,7 @@ private void verifyOneDependencyAdded(final String outputLocation, final boolean
272273
ds.setFileMode(Integer.toString(10, 8));
273274

274275
final MavenSession session = mock(MavenSession.class);
275-
when(session.getProjectBuildingRequest()).thenReturn(mock(ProjectBuildingRequest.class));
276+
when(session.getProjectBuildingRequest()).thenReturn(new DefaultProjectBuildingRequest());
276277
when(session.getUserProperties()).thenReturn(new Properties());
277278
when(session.getSystemProperties()).thenReturn(new Properties());
278279

@@ -447,7 +448,7 @@ public void useDefaultExcludes() throws Exception {
447448
final MavenProject project = new MavenProject(new Model());
448449
project.setGroupId("GROUPID");
449450

450-
ProjectBuildingRequest pbReq = mock(ProjectBuildingRequest.class);
451+
ProjectBuildingRequest pbReq = new DefaultProjectBuildingRequest();
451452
ProjectBuildingResult pbRes = mock(ProjectBuildingResult.class);
452453
when(pbRes.getProject()).thenReturn(project);
453454

0 commit comments

Comments
 (0)