ZOOKEEPER-4020: Fix memory leak from ssl cert in c client

Gowrima · web-flow · commit f7af2acd7f92 · 2024-12-07T13:58:18.000+08:00
Reviewers: kezhuw Author: Gowrima Closes #2209 from Gowrima/ZOOKEEPER-4020
diff --git a/zookeeper-client/zookeeper-client-c/src/zookeeper.c b/zookeeper-client/zookeeper-client-c/src/zookeeper.c
@@ -1454,7 +1454,7 @@ zhandle_t *zookeeper_init_ssl(const char *host, const char *cert, watcher_fn wat
 {
     zcert_t zcert;
     zcert.certstr = strdup(cert);
-    zcert.ca = strtok(strdup(cert), ",");
+    zcert.ca = strtok(zcert.certstr, ",");
     zcert.cert = strtok(NULL, ",");
     zcert.key = strtok(NULL, ",");
     zcert.passwd = strtok(NULL, ",");       

Original file line number	Diff line number	Diff line change
`@@ -1454,7 +1454,7 @@ zhandle_t zookeeper_init_ssl(const char host, const char *cert, watcher_fn wat`
`1454`	`1454`	`{`
`1455`	`1455`	`zcert_t zcert;`
`1456`	`1456`	`zcert.certstr = strdup(cert);`
`1457`		`- zcert.ca = strtok(strdup(cert), ",");`
	`1457`	`+ zcert.ca = strtok(zcert.certstr, ",");`
`1458`	`1458`	`zcert.cert = strtok(NULL, ",");`
`1459`	`1459`	`zcert.key = strtok(NULL, ",");`
`1460`	`1460`	`zcert.passwd = strtok(NULL, ",");`