removed the initialEvents from itemView so that it won't re-render the itemView when the collection is reset, by default

Derick Bailey · Derick Bailey · commit 74527ebbbe60 · 2012-08-09T16:39:14.000-05:00
diff --git a/spec/javascripts/itemView.spec.js b/spec/javascripts/itemView.spec.js
@@ -168,31 +168,6 @@ describe("item view", function(){
     });
   });
 
-  describe("when an item view's collection is reset", function(){
-    var view;
-
-    beforeEach(function(){
-      var collection = new Collection();
-      view = new ItemView({
-        template: "#collectionItemTemplate",
-        collection: collection
-      });
-
-      spyOn(view, "serializeData").andCallThrough();
-
-      collection.reset([ { foo: "bar" }, { foo: "baz" } ]);
-    });
-
-    it("should serialize the collection", function(){
-      expect(view.serializeData).toHaveBeenCalled();
-    });
-
-    it("should render the template with the serialized collection", function(){
-      expect($(view.el)).toHaveText(/bar/);
-      expect($(view.el)).toHaveText(/baz/);
-    });
-  });
-
   describe("when an item view has a model and collection, and is rendered", function(){
     var view;
 
diff --git a/src/backbone.marionette.itemview.js b/src/backbone.marionette.itemview.js
@@ -7,15 +7,9 @@
 Marionette.ItemView =  Marionette.View.extend({
   constructor: function(){
     Marionette.View.prototype.constructor.apply(this, arguments);
-    this.initialEvents();
-  },
 
-  // Configured the initial events that the item view 
-  // binds to. Override this method to prevent the initial
-  // events, or to add your own initial events.
-  initialEvents: function(){
-    if (this.collection){
-      this.bindTo(this.collection, "reset", this.render, this);
+    if (this.initialEvents){
+      this.initialEvents();
     }
   },
 
