more hello. #1
Merged
more hello. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 100529fe986a8414892da02019a6e12a00fd2c67-PR-1
💛 - Coveralls |
chitacan
force-pushed
the
pr_1
branch
5 times, most recently
from
68db612 to
4c1f76b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -33,4 +33,9 @@ defmodule PhxArtifactWeb.ApiController do | |||
| def world(conn, _) do | |||
| json(conn, %{val: "world"}) | |||
| end | |||
|
|
|||
| def more_hello(conn, _) do | |||
| IO.inspect("more_hello") | |||
There was a problem hiding this comment.
[credo] reported by reviewdog 🐶
There should be no calls to IO.inspect/1.
chitacan
force-pushed
the
pr_1
branch
4 times, most recently
from
e3f2773 to
e5db8e6
Compare
chitacan
force-pushed
the
pr_1
branch
3 times, most recently
from
3117b5f to
7e4d350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.