-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Enable HTTP debug and trace for transfer based puller #10762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
928aecc
to
76804c8
Compare
Added local streaming support as suggested by @dmcgowan PTAL. |
/test pull-containerd-node-e2e |
What does the tracing need to use I wonder if we need the debug/trace options at all. If the a debug stream is provided, can we just add the traces or is the format of the debug stream already defined? I still don't like the client being able to force the daemon into a debug mode and utilizing the daemon's logs. I think we could have separate trace (maybe debug, but probably better just for client) config on the daemon side that could add the trace data to the daemon logs. |
For traces, the format of the output is up to us as we implement trace hooks.
Ya, technically we can write in any format as long as we write it to the stream's |
/test pull-containerd-node-e2e |
@mxpv Rebase? |
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@samuelkarp Done. But it now needs another LGTM
|
HTTP debug and traces are pretty useful for debugging interactions between containerd and remote registries. However in current implementation, those don't work with the new transfer service based puller/pusher. This PR updates remote resolver to enable it.