Update slidepicker to meet minimum contrast for UI components #11442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-685 Available widget columns do not meet minimum contrast
Page Area: Dashboard - widget settings HUD Issue Description: The total number of columns is indicated by rectangles using a light hairline color. This hairline color is too light and makes it difficult for users with low vision to understand how many columns there are in total Action: Darken the border color of all available columns to meet 3:1 minimum contrast ratio. This will require that the width indicator uses something other than the darker outline to indicate the current selection Screenshot/Code Snippet: Screenshot showing colspan picker component with light indicator of total number of columns: Screen Shot 2022-06-02 at 12.32.40 PM.png Resolves CMS-230 |
gcamacho079
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
# Conflicts: # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/dashboard/dist/css/Dashboard.css # src/web/assets/dashboard/dist/css/Dashboard.css.map
brandonkelly
requested review from
brianjhanson
and removed request for
a team,
nfourtythree and
benjamindavid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates slidepicker component to meet 3:1 contrast ratio for UI components (resolves DEV-685), and modifies size to meet draft SC 2.5.8 Target Size (Minimum)
Also removes low opacity set on settings button to meet minimum contrast ratio
Widget manager context:
Field layout context: