Skip to content

Feature/dev 736 translatable alt field #12525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Dec 13, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jan 11, 2023

Description

Makes assets’ Alt Text fields translatable.

The alt column in the assets table stays as is and is used for the default alt text. Default alt is one that is saved the first time you add a value to an AltField.

A new table - assets_sites- stores site-specific AltField values.

Translation method/key are set on per volume’s field layout basis.

When you add an AltField value for the first time, the default alt (assets.alt) is filled with data. This mimics the behaviour of adding a value to a new e.g. entry. The value is propagated across all sites.

Any subsequent changes to the AltField value are stored in the assets_sites table and follow the selected translation method.

Related issues

dev-736

@linear
Copy link

linear bot commented Jan 11, 2023

@i-just i-just marked this pull request as ready for review November 14, 2023 11:09
@i-just i-just requested a review from brandonkelly November 14, 2023 11:09
@brandonkelly brandonkelly merged commit 84044b2 into 5.0 Dec 13, 2023
@brandonkelly brandonkelly deleted the feature/dev-736-translatable-alt-field branch December 13, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants