Skip to content

Show/hide slug field option #13905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 28, 2023
Merged

Show/hide slug field option #13905

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
47c8d25
initial work on show/hide slug field
i-just Nov 2, 2023
7a21835
make showSlugField and slugFieldHtml public
i-just Nov 3, 2023
576245f
show/hide slug field on draft save
i-just Nov 3, 2023
561f55e
don't allow setting slug via gql is showSlugField is false
i-just Nov 3, 2023
fdf5af2
tweaks
i-just Nov 3, 2023
39a3573
Merge branch '5.0' into feature/dev-1199-show-slug-field-option
brandonkelly Dec 28, 2023
62aebb4
Fix SQL error when first updating
brandonkelly Dec 28, 2023
3e6ff37
Drop Slug field toggling via autosaves
brandonkelly Dec 28, 2023
7f6f4f4
Release note
brandonkelly Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't allow setting slug via gql is showSlugField is false
  • Loading branch information
@i-just
i-just committed Nov 3, 2023
commit 561f55e2c543c3ec3910bf2645c85cebbf88c32f
13 changes: 13 additions & 0 deletions src/gql/resolvers/mutations/Entry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,19 @@ public function saveEntry(mixed $source, array $arguments, mixed $context, Resol
unset($arguments['enabled']);
}

// If saving an entry the slug is provided, check if we should allow changing it.
if (array_key_exists('slug', $arguments)) {
try {
$showSlugField = $entry->showSlugField();
} catch (InvalidConfigException) {
$showSlugField = true;
}

if (!$showSlugField) {
unset($arguments['slug']);
}
}

// TODO refactor saving draft to its own method in 4.0
if (array_key_exists('draftId', $arguments)) {
$entry->setScenario(Element::SCENARIO_ESSENTIALS);
Expand Down