uncommented for v5; if fs doesn't have URLs or used as temp

craftcms · brandonkelly · Dec 21, 2023 · Nov 21, 2023 · Nov 21, 2023 · Nov 21, 2023
commit c5bd7559543482bc90f5f5862dd022e7fda3e4f9
diff --git a/src/elements/Asset.php b/src/elements/Asset.php
@@ -2046,10 +2046,10 @@ private function _url(mixed $transform = null, ?bool $immediately = null): ?stri
             return $url;
         }
 
-        // todo: uncomment for v5. Currently Imager X is relying on a relative URL being returned
-        //if (!$volume->getFs()->hasUrls) {
-        //    return null;
-        //}
+        $fs = $volume->getFs();
+        if (!$fs->hasUrls || Assets::isUsedForTempUploads($fs)) {
+            return null;
+        }
 
         return Html::encodeSpaces(Assets::generateUrl($volume, $this));
     }