Feature/cms 1373 warn when moving large asset folders #16908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s only show the “Undo” button if there weren’t any conflicts to begin with. If there are conflicts, you already get a chance to cancel the action within the conflict resolution dialog. |
|
Thanks! Done and the PR description updated. |
[ci skip]
brandonkelly
deleted the
feature/cms-1373-warn-when-moving-large-asset-folders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If moving more than 50 items (assets + folders - not counting assets in those folders) or more than 50 MB of assets (including the assets in the folders), warn the user about the move beforehand.
Otherwise, show a toast notification after the move is complete, with an Undo button.
Screen.Recording.2025-03-18.at.10.12.05.mov
If any conflicts were encountered during the initial move, the Undo button won’t be available (even if some assets/folders were moved).
Related issues