User cache invalidation remediation #16937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
approved these changes
Mar 21, 2025
[ci skip]
brandonkelly
deleted the
feature/cms-1380-user-cache-invalidation-remediation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, user caches have been invalidated whenever they:
These were done specifically so user indexes show up-to-date information. However they also can end up inadvertently clearing front-end caches, if any user data is output within
{% cache %}tags, or if the site has full-page caching that monitors all cache tag invalidations (like we do with Craft Cloud).To fix, we’re now assigning
element-index-queryandelement-index-query::<element-type>tags to element index query caches, and when any of the above actions occur, we are now only invalidating caches tagged withelement-index-query::craft\elements\User.(Normal user caches will still be cleared any time a user is fully saved.)
Related issues