Added new RenderElementsEvent #6024
Conversation
|
This would be a breaking change due to the changed interface method. |
Is there anyway to load the source from the sourceId in the event? I think there is… let me play for an hour. |
|
@brandonkelly fixed the PR so there's no breaking changes. The source was already being determined a few lines below so I just moved that up and included it in the event. https://github.com/craftcms/cms/pull/6024/files#diff-73a4b977fac97aabd14c25bdc70a3d5fR583-L587 Turns out this is a very minor code change in the end. |
|
@brandonkelly Do you need me to reissue this to fix the conflicts? I would love to see it in 3.5. |
|
It’s on my list to look into. Merge conflicts should be easily resolved, don’t worry about it :) |
|
broad shoulders, as dependable, @brandonkelly - take care :) |
|
@brandonkelly resolved the conflicts :) as I'm working locally from my fork. |
leevigraham
force-pushed
the
issues/6023
branch
7 times, most recently
from
d5a7a13 to
8cd998c
Compare
leevigraham
force-pushed
the
issues/6023
branch
4 times, most recently
from
90e0f0f to
8de415b
Compare
leevigraham
force-pushed
the
issues/6023
branch
2 times, most recently
from
3ef5cd7 to
8a97cd5
Compare
leevigraham
force-pushed
the
issues/6023
branch
from
8a97cd5 to
5abf559
Compare
The new event allows plugin / module authors to override the template rendering for the elements index container.
leevigraham
force-pushed
the
issues/6023
branch
from
5abf559 to
e8b2a84
Compare
|
@brandonkelly Just listened to the devode.fm podcast… 😂 |
|
Hahaha, sorry LG :) |
|
@brandonkelly All good, glad you like the concept. Closing this just saves me a force push and managing two forks :) |
The new event allows plugin / module authors to override the template rendering for the elements index container.