-
Notifications
You must be signed in to change notification settings - Fork 652
#1259 - fix ticket_list sorting #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
finnertysea
wants to merge
2
commits into
django-helpdesk:main
Choose a base branch
from
finnertysea:#1259--fix-ticket-list-sorting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#1259 - fix ticket_list sorting #1260
finnertysea
wants to merge
2
commits into
django-helpdesk:main
from
finnertysea:#1259--fix-ticket-list-sorting
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just confirmed that sorting does not work in the latest commit 1f22f54. I am now going to test the fix. |
I still cant replicate the success. Can you tell me what database you're using and the python/django versions? The standalone uses postgresql 17 and python --version
Python 3.11.12
pip list
...
Django 5.2
django-appconf 1.1.0
django-bootstrap4-form 4.0.2
django-cleanup 9.0.0
django-helpdesk 1.4.0 /opt/django-helpdesk
django-model-utils 5.0.0
django-reversion 5.1.0
django-user-accounts 3.3.2
djangorestframework 3.16.0
... Also I'm going to bring in the big guns as they might have a better idea of whats happening. |
I will be completely offline for the next 12 days but will review as soon
as I can.
…On Thu, 24 Apr 2025, 11:50 pm David Vadnais, ***@***.***> wrote:
@DavidVadnais <https://github.com/DavidVadnais> requested your review on:
#1260 <#1260> #1259
<#1259> - fix
ticket_list sorting.
—
Reply to this email directly, view it on GitHub
<#1260 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFWYMS6A74FLQWKD6TJ3W323FMCFAVCNFSM6AAAAAB3N27CROVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGM4TONZXGAZDIOI>
.
You are receiving this because your review was requested.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to sorting.html:
changes to get_datatables_context():