Skip to content

Changes DemoConsole and DesignSurfaceExt projects to adopt implicit usings #12885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Feb 6, 2025

Related #12830

Proposed changes

  • Changes DemoConsole and DesignSurfaceExt projects to adopt implicit usings.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test environment(s)

  • 10.0.100-alpha.1.25077.2

@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Feb 6, 2025
@ricardobossan ricardobossan force-pushed the Issue_12830_Make_DemoConsole_MultiTarget branch 2 times, most recently from 85b1d5d to ec1c3db Compare February 7, 2025 22:46
@ricardobossan ricardobossan force-pushed the Issue_12830_Make_DemoConsole_MultiTarget branch from ec1c3db to d24f80d Compare February 11, 2025 14:38
@ricardobossan ricardobossan force-pushed the Issue_12830_Make_DemoConsole_MultiTarget branch from fc38715 to 7ba5e21 Compare February 19, 2025 19:27
@ricardobossan ricardobossan changed the title Progress in making DemoConsole multi-target Changes DemoConsole and DesignSurfaceExt projects to adopt implicit usings Feb 19, 2025
@ricardobossan ricardobossan force-pushed the Issue_12830_Make_DemoConsole_MultiTarget branch from 7ba5e21 to 8d68587 Compare February 19, 2025 19:30
@ricardobossan ricardobossan added waiting-review This item is waiting on review by one or more members of team and removed draft draft PR labels Feb 19, 2025
@ricardobossan ricardobossan marked this pull request as ready for review February 19, 2025 19:33
@ricardobossan ricardobossan requested a review from a team as a code owner February 19, 2025 19:33
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.05224%. Comparing base (cc63bc6) to head (8d68587).
Report is 4 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12885         +/-   ##
===================================================
+ Coverage   76.04976%   76.05224%   +0.00247%     
===================================================
  Files           3267        3267                 
  Lines         643459      643459                 
  Branches       47432       47432                 
===================================================
+ Hits          489349      489365         +16     
+ Misses        150543      150531         -12     
+ Partials        3567        3563          -4     
Flag Coverage Δ
Debug 76.05224% <ø> (+0.00247%) ⬆️
integration 18.12060% <ø> (+0.00209%) ⬆️
production 50.05007% <ø> (+0.00557%) ⬆️
test 96.93598% <ø> (ø)
unit 47.42243% <ø> (+0.02965%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Feb 21, 2025
@ricardobossan ricardobossan merged commit f280449 into dotnet:main Feb 21, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 21, 2025
LeafShi1 pushed a commit to LeafShi1/winforms that referenced this pull request Mar 6, 2025
…sings (dotnet#12885)

Adds implicit usings to DemoConsole and DesignSurfaceExt projects

Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants