-
Notifications
You must be signed in to change notification settings - Fork 1k
Changes DemoConsole and DesignSurfaceExt projects to adopt implicit usings #12885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ricardobossan
merged 1 commit into
dotnet:main
from
ricardobossan:Issue_12830_Make_DemoConsole_MultiTarget
Feb 21, 2025
Merged
Changes DemoConsole and DesignSurfaceExt projects to adopt implicit usings #12885
ricardobossan
merged 1 commit into
dotnet:main
from
ricardobossan:Issue_12830_Make_DemoConsole_MultiTarget
Feb 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
....Windows.Forms/tests/IntegrationTests/DesignSurface/DesignSurfaceExt/DesignSurfaceExt.csproj
Outdated
Show resolved
Hide resolved
85b1d5d
to
ec1c3db
Compare
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/DemoConsole.csproj
Outdated
Show resolved
Hide resolved
ec1c3db
to
d24f80d
Compare
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/DemoConsole.csproj
Outdated
Show resolved
Hide resolved
...stem.Windows.Forms/tests/IntegrationTests/DesignSurface/DesignSurfaceExt/DesignSurfaceExt.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Feb 17, 2025
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/DemoConsole/DemoConsole.csproj
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Feb 17, 2025
src/System.Windows.Forms/tests/IntegrationTests/DesignSurface/desc.xml
Outdated
Show resolved
Hide resolved
fc38715
to
7ba5e21
Compare
7ba5e21
to
8d68587
Compare
Tanya-Solyanik
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12885 +/- ##
===================================================
+ Coverage 76.04976% 76.05224% +0.00247%
===================================================
Files 3267 3267
Lines 643459 643459
Branches 47432 47432
===================================================
+ Hits 489349 489365 +16
+ Misses 150543 150531 -12
+ Partials 3567 3563 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
approved these changes
Feb 20, 2025
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
…sings (dotnet#12885) Adds implicit usings to DemoConsole and DesignSurfaceExt projects Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <v-rbossan@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #12830
Proposed changes
Customer Impact
Regression?
Risk
Test environment(s)