Skip to content

make it easier to run the test app in the dark mode if needed #12980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Tanya-Solyanik
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik commented Feb 19, 2025

Start the interactive test in the classic mode, but this is a reminder to test this app in the dark mode as well.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the idea!

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.95656%. Comparing base (f82adc1) to head (5348b6c).
Report is 11 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f82adc1) and HEAD (5348b6c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f82adc1) HEAD (5348b6c)
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12980          +/-   ##
====================================================
- Coverage   96.95014%   49.95656%   -46.99358%     
====================================================
  Files           1218        2048         +830     
  Lines         356738      286607       -70131     
  Branches        5525       41904       +36379     
====================================================
- Hits          345858      143179      -202679     
- Misses         10040      140710      +130670     
- Partials         840        2718        +1878     
Flag Coverage Δ
Debug 49.95656% <ø> (-46.99359%) ⬇️
integration 18.03594% <ø> (?)
production 49.95656% <ø> (?)
test ?
unit 47.38824% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik merged commit 226b1db into dotnet:main Feb 19, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview3 milestone Feb 19, 2025
@Tanya-Solyanik
Copy link
Member Author

Really like the idea!

We can add a dynamic selection of the mode later

@Tanya-Solyanik Tanya-Solyanik deleted the dark-test branch February 25, 2025 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants