Flip nullable enable on System.Windows.Forms.Tests. #13063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a simple script using ChatGPT that did most of the lifting. There were a couple of files that had a mix of states that I manually fixed up. Script isn't perfect, ran the auto fix for multiple blank lines. Here is the script generation: https://chatgpt.com/share/67c6065d-8738-8006-a290-28614ddb874e
JeremyKuhne
added a commit
to JeremyKuhne/winforms
that referenced
this pull request
Mar 3, 2025
Enables nullable by default in SWFDT. See dotnet#13063 for more context.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13063 +/- ##
====================================================
- Coverage 96.95044% 76.10636% -20.84409%
====================================================
Files 1225 3275 +2050
Lines 357134 643803 +286669
Branches 5537 47445 +41908
====================================================
+ Hits 346243 489975 +143732
- Misses 10049 150266 +140217
- Partials 842 3562 +2720
Flags with carried forward coverage won't be shown. Click here to find out more. |
Shyam-Gupta
approved these changes
Mar 4, 2025
JeremyKuhne
added a commit
that referenced
this pull request
Mar 4, 2025
Enables nullable by default in SWFDT. See #13063 for more context.
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
Created a simple script using ChatGPT that did most of the lifting. There were a couple of files that had a mix of states that I manually fixed up. Script isn't perfect, ran the auto fix for multiple blank lines. Here is the script generation: https://chatgpt.com/share/67c6065d-8738-8006-a290-28614ddb874e
LeafShi1
pushed a commit
to LeafShi1/winforms
that referenced
this pull request
Mar 6, 2025
…et#13064) Enables nullable by default in SWFDT. See dotnet#13063 for more context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a simple script using ChatGPT that did most of the lifting. There were a couple of files that had a mix of states that I manually fixed up. Script isn't perfect, ran the auto fix for multiple blank lines.
Here is the script generation:
https://chatgpt.com/share/67c6065d-8738-8006-a290-28614ddb874e
Microsoft Reviewers: Open in CodeFlow