Add balance total after each transactions #570
Conversation
Arkarr
force-pushed
the
feature/add_balance_to_transactions
branch
from
f5eba4b to
b219468
Compare
|
Hi, thank you for this! I'll have a detailed look at this probably over the weekend. After a first quick look, this only works on account transaction pages, not the overall (main) transaction page, correct? Have you looked at implementing it for the main transaction page as well?
Just for me, what's your coding experience so far? At a first glance the code looks pretty good 😄 |
dreautall
added
enhancement
|
Yeah, no worries. I am not in a hurry :) Although, it could definitely facilitate my life. I look forward that feature a lot.
I didn't want to - It might be confusing to view balances not aligning with the transactions above and/or under it. But if you think that's necessary, the logic should remain more or less the same.
I do it for a living. |
|
Just added a couple of code-style comments - didn't have time to spin up the emulator for now, sorry. I'm especially interested in the
More than me then 😉 So it's really only dart you're unfamiliar with I guess! |
Hi,
This pull request is primarily made to answer to the following issue : #568
It should display account balance after each transactions.
The changes are summarized below :
I created three variables :
_runningBalancesByTransactionId,_lastCalculatedBalanceand_balanceAccountwhich store the balance for each transaction, store the last calculated balance and store a reference to the account respectively.I created three helper functions
_parseBalance,_isRevenueOrExpense,_updateBalance- maybe they should be moved else where.Lines 267-288: This is where I update for each transactions the balance based on the last balance (either
_lastCalculatedBalanceor the actual account's balance)Lines 725-739: When a transaction is edited for some reasons, the account linked to the transaction is being fetched and the balance is being re-calculated. This part of the code should probably be optimized.
I updated the syntax of some part of the code too.
Unit tests might be a good thing to add some days in the future. Maybe.
Disclaimer:
I never ever developed for mobiles, used Dart language nor used the "Flutter" framework.