radical idea ... write unit tests so code I check in does not act in all sorts of random ways

SamSaffron · SamSaffron · commit 6de1a936f88e · 2012-02-09T17:30:32.000+11:00
diff --git a/StackExchange.Profiling.Tests/StackExchange.Profiling.Tests.csproj b/StackExchange.Profiling.Tests/StackExchange.Profiling.Tests.csproj
@@ -74,6 +74,7 @@
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="MiniProfilerTest.cs" />
     <Compile Include="Storage\SqlServerStorageTest.cs" />
+    <Compile Include="Storage\TestHttpRuntimeCacheStorage.cs" />
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />
diff --git a/StackExchange.Profiling.Tests/Storage/TestHttpRuntimeCacheStorage.cs b/StackExchange.Profiling.Tests/Storage/TestHttpRuntimeCacheStorage.cs
@@ -0,0 +1,58 @@
+﻿using System;
+using System.Text;
+using System.Collections.Generic;
+using System.Linq;
+using StackExchange.Profiling.Storage;
+using NUnit.Framework;
+
+namespace StackExchange.Profiling.Tests.Storage
+{
+    [TestFixture]
+    public class TestHttpRuntimeCacheStorage
+    {
+        [Test]
+        public void TestWeCanSaveTheSameProfilerTwice()
+        {
+            var profiler = new MiniProfiler();
+            profiler.Started = DateTime.UtcNow;
+            profiler.Id = Guid.NewGuid();
+            var storage = new HttpRuntimeCacheStorage(new TimeSpan(1,0,0));
+            storage.Save(profiler);
+            storage.Save(profiler);
+            var guids = storage.List(100);
+            Assert.AreEqual(profiler.Id, guids.First());
+            Assert.AreEqual(1, guids.Count());
+        }
+
+        [Test]
+        public void TestRangeQueries()
+        {
+            var now = DateTime.UtcNow;
+            var inASec = now.AddSeconds(1);
+            var in2Secs = now.AddSeconds(2);
+            var in3Secs = now.AddSeconds(3);
+            var profiler = new MiniProfiler { Started = now, Id = Guid.NewGuid() };
+            var profiler1 = new MiniProfiler { Started = inASec, Id = Guid.NewGuid() };
+            var profiler2 = new MiniProfiler { Started = in2Secs, Id = Guid.NewGuid() };
+            var profiler3 = new MiniProfiler { Started = in3Secs, Id = Guid.NewGuid() };
+            
+            var storage = new HttpRuntimeCacheStorage(new TimeSpan(1, 0, 0));
+
+            storage.Save(profiler);
+            storage.Save(profiler3);
+            storage.Save(profiler2);
+            storage.Save(profiler1);
+
+            var guids = storage.List(100);
+            Assert.AreEqual(4, guids.Count());
+
+            guids = storage.List(1);
+            Assert.AreEqual(1, guids.Count());
+
+            guids = storage.List(2, now, in2Secs, ListResultsOrder.Decending);
+            Assert.AreEqual(profiler2.Id, guids.First());
+            Assert.AreEqual(profiler1.Id, guids.Skip(1).First());
+            Assert.AreEqual(2, guids.Count());
+        }
+    }
+}
diff --git a/StackExchange.Profiling/Storage/HttpRuntimeCacheStorage.cs b/StackExchange.Profiling/Storage/HttpRuntimeCacheStorage.cs
@@ -57,12 +57,16 @@ public void Save(MiniProfiler profiler)
             
             lock (profiles)
             {
-                profiles.Add(new ProfileInfo { Id = profiler.Id, Started = profiler.Started }, null);
+                var profileInfo = new ProfileInfo { Id = profiler.Id, Started = profiler.Started };
+                if (profiles.IndexOfKey(profileInfo) < 0) 
+                {
+                    profiles.Add(profileInfo, null);
+                }
 
                 while (profiles.Count > 0)
                 {
                     var first = profiles.Keys[0];
-                    if (first.Started < DateTime.Now.Add(-CacheDuration))
+                    if (first.Started < DateTime.UtcNow.Add(-CacheDuration))
                     {
                         profiles.RemoveAt(0);
                     }
@@ -182,24 +186,32 @@ public IEnumerable<Guid> List(int maxResults, DateTime? start = null, DateTime?
             lock (profiles)
             {
                 int idxStart = 0;
-                int idxFinish = 0;
+                int idxFinish = profiles.Count - 1;
                 if (start != null) idxStart = BinaryClosestSearch(start.Value);
                 if (finish != null) idxFinish = BinaryClosestSearch(finish.Value);
 
-                int delta = 1;
-                if (orderBy == ListResultsOrder.Decending)
-                {
-                    delta = -1;
-                    int tmp = idxStart;
-                    idxStart = idxFinish;
-                    idxFinish = idxStart;
-                }
+                if (idxStart < 0) idxStart = 0;
+                if (idxFinish >= profiles.Count) idxFinish = profiles.Count - 1;
+
                 var keys = profiles.Keys;
 
-                for (int i = idxStart; i < idxFinish; i+=delta)
+                if (orderBy == ListResultsOrder.Ascending)
+                {
+                    for (int i = idxStart; i <= idxFinish; i++)
+                    {
+                        guids.Add(keys[i].Id);
+                        if (guids.Count == maxResults) break;
+                    }
+                }
+                else
                 {
-                    guids.Add(keys[i].Id);
+                    for (int i = idxFinish; i >= idxStart; i--)
+                    {
+                        guids.Add(keys[i].Id);
+                        if (guids.Count == maxResults) break;
+                    }
                 }
+               
             }
             return guids;
         }
