DecimalField accepts 2E+2 as 200 and validates decimal place correctly.
#2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decimal place correctly.
|
Here's the failure... https://travis-ci.org/tomchristie/django-rest-framework/jobs/63027829 |
|
@tomchristie fixed |
|
Annoying, I ran the tests against master and it already works. |
Then I'd suggest a pull request with just the test, and if that's okay then close this one off until/unless we have a failing test to progress against. |
|
This is weird, I always first write failing test and then fix issue, I am sure when I posted PR it was failing. Will check at monday if it is still the case on master! 👍 |
|
I double checked and have no idea why it didn't fail yesterday. |
xordoquy
added a commit
that referenced
this pull request
May 29, 2015
Added test ensuring DecimalField accepts `2E+2` as 200 and validates decimal place correctly.
xordoquy
changed the title
2E+2 as 200 and validates decimal place correctly.DecimalField accepts 2E+2 as 200 and validates decimal place correctly.
|
Thanks :) |
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Nov 14, 2017
This was referenced Dec 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2947
No idea why Travis failed, but I run all tests and all passed.