deal with zeroes in estimate_truncation
#301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbfnk
changed the title
estimate_truncation
seabbs
approved these changes
Jul 15, 2022
inst/stan/estimate_truncation.stan
Outdated
| // log density of truncated latest data vs that observed | ||
| for (i in 1:(obs_sets - 1)) { | ||
| int start_t = t - obs_dist[i] - trunc_max[1]; | ||
| for (j in 1:trunc_max[1]) { | ||
| obs[start_t + j, i] ~ neg_binomial_2(trunc_obs[j, i], sqrt_phi); | ||
| obs[start_t + j, i] ~ neg_binomial_2(trunc_obs[j, i] + sigma, sqrt_phi); |
There was a problem hiding this comment.
If this is initialised to a temporary variable it will be faster vs being done in the likelihood.
There was a problem hiding this comment.
That seems mad but can just add it to trunc_obs
|
Merged in the (current) absence of a better solution. |
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
estimate_truncationfunction currently can't deal with observed zeroes - this adds a small noise parameter to fix that