-
Notifications
You must be signed in to change notification settings - Fork 37
limit touchstone to stan model changes #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we add it to the commit message? So rather than triggering all the time code is touched only trigger when code is touched and a commit contains [benchmark]? This could be a pain as people will need to know to trigger the benchmark but could be a good option if working on R side code that impacts the stan model? Or alternatively, change it to look for PR comments but that might be complicated. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 63d8631 is merged into main:
|
These are both great suggestions but I think would either require a separate workflow file or some fairly involved logic inside the workflow body to check whether the benchmark was triggered by a change in stan code or a trigger commit message. As a simpler solution how about we add a |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if a4aad24 is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* limit touchstone to stan model changes * add news item and increase dev version * add manual trigger * update news item with review
Fixed #399.
We could add a manual trigger but I'm not sure we'd be able to see the results without being embedded in a PR.