Skip to content

Update install info #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2023
Merged

Update install info #407

merged 9 commits into from
Jun 9, 2023

Conversation

jamesmbaazam
Copy link
Contributor

This PR closes #376 by replacing the use of remotes with pak in the installation guide. pak offers lots a number of advantages, including speed, for building and installing packages and their dependencies.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 79cba5b is merged into main:

  •   :ballot_box_with_check:default: 47.4s -> 47s [-16.52%, +14.88%]
  •   :ballot_box_with_check:no_delays: 40s -> 42.1s [-6.77%, +17.31%]
  •   :ballot_box_with_check:random_walk: 12.2s -> 12.4s [-8.8%, +11.83%]
  •   :ballot_box_with_check:stationary: 30.7s -> 30.3s [-9.62%, +6.86%]
  •   :ballot_box_with_check:uncertain: 48.7s -> 49.4s [-17.31%, +19.95%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@seabbs
Copy link
Contributor

seabbs commented Jun 4, 2023

Thanks James,

Needs:

  • News
  • Dev version increment
  • Detail on which platforms you have tested install with
  • A note in the README linking to pak and indicating the alternative if it doesn't work on your platform (i.e. remotes)

@jamesmbaazam jamesmbaazam force-pushed the update_install_info branch from e7da5e8 to 842d9a3 Compare June 8, 2023 12:20
@jamesmbaazam
Copy link
Contributor Author

jamesmbaazam commented Jun 8, 2023 •
edited
Loading

Thanks, @seabbs. I've made the changes. Ready for review.

seabbs
seabbs requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there.

@jamesmbaazam jamesmbaazam requested a review from seabbs June 9, 2023 09:05
seabbs
seabbs approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seabbs seabbs merged commit bce44c0 into epiforecasts:main Jun 9, 2023
sbfnk pushed a commit that referenced this pull request May 3, 2024
@jamesmbaazam @seabbs
Update install info (#407)
60dda32 
* Updated wordlist

* Replaced remotes with pak as developmental install option

* Updated news

* Suggested both pak and remotes for dev installation

* Updated wordlist

* Incremented dev version

* Rendered the README

* Fit the news item on one line

---------

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update installation information; suggest pak
2 participants
@jamesmbaazam @seabbs