Skip to content

make estimate_truncation return a dist_spec #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2023
Merged

make estimate_truncation return a dist_spec #452

merged 3 commits into from
Sep 11, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 8, 2023

Fixes #449

seabbs
seabbs approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice.

@sbfnk sbfnk merged commit 05512ca into main Sep 11, 2023
@seabbs seabbs deleted the issue-449 branch September 11, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

estimate_truncation should return a call to dist_spec
2 participants
@sbfnk @seabbs