Skip to content

deprecate fixed argument to dist_spec #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2023
Merged

deprecate fixed argument to dist_spec #503

merged 2 commits into from
Nov 10, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Nov 9, 2023

Deprecates the fixed argument in dist_spec as this can now be done with fix_dist() so that we can trim down the argument list.

@jamesmbaazam
Copy link
Contributor

I'm going to fix the linting issues so we can merge and rebase these branches.

@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 9, 2023

I'm going to fix the linting issues so we can merge and rebase these branches.

Thanks but I think I've done it already in 4d85b6d so we should be able to rebase once that's merged.

seabbs
seabbs reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs a news item

@sbfnk sbfnk merged commit 69434d3 into main Nov 10, 2023
@sbfnk sbfnk deleted the deprecate-fixed branch November 10, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbfnk @jamesmbaazam @seabbs