Skip to content

Fixed rep phi #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Fixed rep phi #560

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a46c11
bring phi specification in line with scale
sbfnk Feb 14, 2024
7998d04
support and deprecate legacy option
sbfnk Feb 14, 2024
72d4f47
update stan model
sbfnk Feb 14, 2024
ad80dfe
update tests
sbfnk Feb 14, 2024
e007e5e
add news item
sbfnk Feb 20, 2024
dc21eae
add PR number and reviewer
sbfnk Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
support and deprecate legacy option
  • Loading branch information
@sbfnk @seabbs
sbfnk authored and seabbs committed Feb 20, 2024
commit 7998d04cfb6b5b684249fcccfa3adc2a13444c4c
7 changes: 7 additions & 0 deletions R/opts.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,13 @@ obs_opts <- function(family = "negbin",
)
}

if (length(phi) == 2 && is.numeric(phi)) {
warning(
"Specifying `phi` as a length 2 vector is deprecated. Mean and SD ",
"should be given as list elements."
)
phi <- list(mean = phi[1], sd = phi[2])
}
obs <- list(
family = arg_match(family, values = c("poisson", "negbin")),
phi = phi,
Expand Down