Skip to content

Only set seeds in testing when needed. #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Only set seeds in testing when needed. #590

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d74d24b
remove unneeded seeds
sbfnk Mar 1, 2024
3d0f864
update snapshots
sbfnk Mar 1, 2024
31e10e2
add news item
sbfnk Mar 1, 2024
069980d
add missing dependency
sbfnk Mar 1, 2024
855befd
add reviewer
sbfnk Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add news item
  • Loading branch information
@sbfnk @seabbs
sbfnk authored and seabbs committed Mar 1, 2024
commit 31e10e2f42bda95148a5d762d2ad175cc9c39d0b
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
* Added the possibility of specifying a fixed observation scaling. By @sbfnk in #550 and reviewed by @seabbs.
* Added the possibility of specifying fixed overdispersion. By @sbfnk in #560 and reviewed by @seabbs.
* The example in `estimate_truncation()` has been simplified. The package now ships with a dataset `example_truncated`, which is used in the `estimate_truncation()` example and tests. The steps for creating the `example_truncated` is stored in `./data-raw/estimate-truncation.R`. By @jamesmbaazam in #584 and reviewed by @seabbs and @sbfnk.
* Tests have been updated to only set random seeds before snapshot tests involving random number generation, and unset them subsequently. By @sbfnk in .

## Model changes

Expand Down