Skip to content

Fix relative links in README #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 19, 2024
Merged

Fix relative links in README #617

merged 13 commits into from
Mar 19, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #596 by fixing broken links in the README.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam jamesmbaazam marked this pull request as draft March 18, 2024 14:30
@jamesmbaazam jamesmbaazam marked this pull request as ready for review March 18, 2024 16:47
Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

jamesmbaazam and others added 2 commits March 18, 2024 18:03
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@jamesmbaazam jamesmbaazam reopened this Mar 19, 2024
@sbfnk sbfnk merged commit f6c707b into main Mar 19, 2024
11 checks passed
@sbfnk sbfnk deleted the relative-links branch March 19, 2024 21:18
sbfnk added a commit that referenced this pull request May 3, 2024
* Fix relative link for Getting Started vignette

* Add ./ to relative links

* Add NEWS item

* Automatic readme update

* Fix url according to pkgdown_sitrep recommendation

* Use the released package website url

* Revert ./ syntax

* Automatic readme update

* Reword and replace urls with calls to vignette()

* Reword to refer to dev and stable sites

* Update NEWS.md

* Apply suggestions from code review

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Automatic readme update

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
sbfnk added a commit that referenced this pull request May 3, 2024
* Fix relative link for Getting Started vignette

* Add ./ to relative links

* Add NEWS item

* Automatic readme update

* Fix url according to pkgdown_sitrep recommendation

* Use the released package website url

* Revert ./ syntax

* Automatic readme update

* Reword and replace urls with calls to vignette()

* Reword to refer to dev and stable sites

* Update NEWS.md

* Apply suggestions from code review

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Automatic readme update

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in package README not going to website
3 participants