-
Notifications
You must be signed in to change notification settings - Fork 37
improve handling of seeding time in simulate_infections()
#627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
windows test |
Sorry, I'm yet to review the part when |
Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Oopsie! I was reviewing it at the same time as you were merging. |
That was the merge queue automatically merging as soon as you approved. |
Oh, cool! It happened so fast, I thought there was a clash. |
* add `seeding_time` arg to `simulate_inections()` * adjust initial infections to exp growth * add news item * update snapshot * update other snapshot * test seeding time setting * update snapshot * Apply suggestions from code review Co-authored-by: James Azam <james.azam@lshtm.ac.uk> * re-generate documentation --------- Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
* add `seeding_time` arg to `simulate_inections()` * adjust initial infections to exp growth * add news item * update snapshot * update other snapshot * test seeding time setting * update snapshot * Apply suggestions from code review Co-authored-by: James Azam <james.azam@lshtm.ac.uk> * re-generate documentation --------- Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
Description
This PR closes #626.
It adds a
seeding_time
argument, adjusts the initial number of infections, and improves the documentation.Using the example from the linked issue now yields:
Created on 2024-03-26 with reprex v2.1.0
It starts with 100 infections as expected and the first data point shown is the number of infections occurring on the following day.
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request