Skip to content

Update documentation of dots in stan_sampling_opts() #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

jamesmbaazam
Copy link
Contributor

Description

This PR closes #696.

This PR fixes an omission in the documentation of the dots argument of the stan_sampling_opts() to add that the dots are passed to cmdstanr::sample() too.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam jamesmbaazam requested review from sbfnk and seabbs June 19, 2024 17:36
sbfnk
sbfnk previously approved these changes Jun 27, 2024
@jamesmbaazam jamesmbaazam changed the title Dots are only passed to rstan sampling here Update documentation of dots in stan_sampling_opts() Jun 27, 2024
@jamesmbaazam jamesmbaazam force-pushed the update-stan-sampling-opts-docs branch from f400fbb to a09dbc9 Compare July 1, 2024 14:54
@sbfnk sbfnk merged commit 35409a6 into main Jul 2, 2024
9 checks passed
@sbfnk sbfnk deleted the update-stan-sampling-opts-docs branch July 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update stan_sampling_opts() documentation of ...
2 participants