Skip to content

fix_dist -> fix_parameters #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 20, 2024
Merged

fix_dist -> fix_parameters #733

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b79631
fix_dist -> fix_parameters
sbfnk Aug 2, 2024
c416f51
Apply suggestions from code review
sbfnk Sep 19, 2024
6216df5
fix deprecation syntax
sbfnk Sep 19, 2024
ce9bf9d
add deprecation test
sbfnk Sep 19, 2024
20451cc
use cli for lintr
sbfnk Sep 20, 2024
46793c0
Apply suggestions from code review
sbfnk Sep 20, 2024
e01dc6a
break line for lintr
sbfnk Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: James Azam <james.azam@lshtm.ac.uk>
  • Loading branch information
@sbfnk @jamesmbaazam
sbfnk and jamesmbaazam authored Sep 20, 2024
commit 46793c08fce311e79499270757ebce4ce5ef8035
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

## Package changes

- `fix_dist()` has been renamed to `fix_parameters()`. By @sbfnk in #733 and reviewed by @jamesmbaazam.
- `fix_dist()` has been renamed to `fix_parameters()` because it removes the uncertainty in a distribution's parameters. By @sbfnk in #733 and reviewed by @jamesmbaazam.

## Bug fixes

Expand Down
4 changes: 2 additions & 2 deletions R/deprecated.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,10 +624,10 @@
return(y)
}

#' Fix the parameters of a `<dist_spec>`
#' Remove uncertainty in the parameters of a `<dist_spec>`
#'
#' @description `r lifecycle::badge("deprecated")`
#' This function has been renamed to [fix_parameters()].
#' This function has been renamed to [fix_parameters()] as the former was a misnomer.

Check warning on line 630 in R/deprecated.R

View workflow job for this annotation

GitHub Actions / lint-changed-files 

file=R/deprecated.R,line=630,col=81,[line_length_linter] Lines should not be more than 80 characters. This line is 85 characters.
#' @return A `<dist_spec>` object without uncertainty
#' @keywords internal
#' @importFrom cli cli_abort
Expand Down
Loading