Check tail of nonparametric PMFs #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
force-pushed
the
check-sparse-pmfs
branch
from
0095421 to
25dfb69
Compare
jamesmbaazam
changed the title
seabbs
reviewed
Aug 22, 2024
Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
seabbs
approved these changes
Aug 22, 2024
jamesmbaazam
added a commit
that referenced
this pull request
Aug 27, 2024
* Add function to check pmf tail * Add test * Apply tail check to pmf * Add NEWS item * Improve documentation * Update NEWS.md Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com> --------- Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #738.
This PR adds a check on the tail of a supplied nonparametric vector to see if consecutive values are below a certain threshold and throws a warning if so. See the linked issue and this comment for an explanation of the rationale for this check. In summary, it is an optimisation issue.
Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).After the initial Pull Request