Skip to content

Replace base R message/warning/stop with {cli} #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 1, 2024
Merged

Replace base R message/warning/stop with {cli} #762

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
772c966
Add lintr to catch use of base for condition signalling
jamesmbaazam Aug 28, 2024
beddcff
Add stopifnot to undesirable functions
jamesmbaazam Aug 29, 2024
28c727e
Add cli to imports
jamesmbaazam Aug 29, 2024
ed4784c
Roxygen version bump
jamesmbaazam Aug 29, 2024
18a6e99
Replace base messages with cli everywhere
jamesmbaazam Aug 29, 2024
4381caf
Generate NAMESPACE
jamesmbaazam Aug 29, 2024
8d4f67a
Replace use of base messages with cli (after rebase conflicts)
jamesmbaazam Aug 29, 2024
1ddc2e7
Add NEWS item
jamesmbaazam Aug 29, 2024
5ecea12
Add reviewer
jamesmbaazam Aug 30, 2024
61bad02
Import col_blue
jamesmbaazam Aug 30, 2024
f97dc28
Fix interpolation
jamesmbaazam Aug 30, 2024
149161d
Fix check on R
jamesmbaazam Aug 30, 2024
cfd15b6
Fix expected messages
jamesmbaazam Aug 30, 2024
27641c6
Fix failing error test because of deprecation warning
jamesmbaazam Aug 30, 2024
65a8b2f
Fix expected errors
jamesmbaazam Aug 30, 2024
ef061a3
Fix logic
jamesmbaazam Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix interpolation
  • Loading branch information
@jamesmbaazam
jamesmbaazam committed Aug 30, 2024
commit f97dc2807ff7baad8d1b5a2e4b3f61032cbc2d39
6 changes: 3 additions & 3 deletions R/setup.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,22 @@ setup_logging <- function(threshold = "INFO", file = NULL,
if (!is.null(file)) {
if (mirror_to_console) {
cli_inform(
"Writing {col_blue(\"name\")} logs to the console and: {.file file}."
"Writing {col_blue(name)} logs to the console and: {.file {file}}."
)
futile.logger::flog.appender(
futile.logger::appender.tee(file), name = name
)
} else {
cli_inform(
"Writing {col_blue(\"name\"} logs to: {.file file}."
"Writing {col_blue(name)} logs to: {.file {file}}."
)
futile.logger::flog.appender(
futile.logger::appender.file(file), name = name
)
}
} else {
cli_inform(
"Writing {col_blue(\"name\"} logs to the console."
"Writing {col_blue(name)} logs to the console."
)
futile.logger::flog.appender(futile.logger::appender.console(), name = name)
}
Expand Down