Skip to content

AnimationTree documentation simplification and expansion #10072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

saabdo42
Copy link
Contributor

@saabdo42 saabdo42 commented Oct 11, 2024

Simplified AnimationTree language, added documentation for Advance Expression, made images webp and colorblind friendly with more descriptive names.

Fixes: #9699
Fixes: #7753
Fixes: #7658

@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 11, 2024
@AThousandShips AThousandShips requested a review from a team October 11, 2024 16:58
@fire
Copy link
Member

fire commented Oct 11, 2024

Is there a good way to preview doc changes?

@fire fire changed the title AnimationTree simplification and expansion AnimationTree documentation simplification and expansion Oct 11, 2024
@fire
Copy link
Member

fire commented Oct 11, 2024

Not familiar with spinx errors.

Warning, treated as error:
/home/runner/work/godot-docs/godot-docs/tutorials/animation/animation_tree.rst:19:Title underline too short.

AnimationTree and AnimationPlayer
-------------------------
make: *** [Makefile:37: dummy] Error 2

@saabdo42
Copy link
Contributor Author

Ok just fixed that error

@saabdo42
Copy link
Contributor Author

I'm not sure how to assign issues to pull requests, but this fixes #9699 and #7753

@fire
Copy link
Member

fire commented Oct 12, 2024

Add this to your first post.

Fixes: https://github.com/godotengine/godot-docs/issues/9699
Fixes: https://github.com/godotengine/godot-docs/issues/7753

@skyace65
Copy link
Contributor

This PR needs to be rebased.

@skyace65 skyace65 added the needs work Needs additional work by the original author, someone else or in another repo. label Oct 29, 2024
@saabdo42
Copy link
Contributor Author

What does that mean? (sorry lol)

@fire
Copy link
Member

fire commented Oct 31, 2024

Let me know if you have any questions after reading this. https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html

@skyace65 skyace65 removed the needs work Needs additional work by the original author, someone else or in another repo. label Nov 7, 2024
@saabdo42
Copy link
Contributor Author

Any update on this?

@skyace65
Copy link
Contributor

Still need to review this, apologies for the long wait

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got around to looking at this

@fire
Copy link
Member

fire commented Mar 31, 2025

I'll put a bookmark that someone from the animation team needs to look at this.

@skyace65 skyace65 merged commit dd17a4c into godotengine:master Jun 8, 2025
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Jun 8, 2025

Merging this as is due to the lack of a response from the animation team.

@saabdo42 Thanks! Apologies on how long this took, congrats on your first merged PR!

@fire fire requested a review from TokageItLab June 8, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.4 enhancement
Projects
None yet
4 participants