Skip to content

[Jolt] Remove reference to removed setting #11005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

AThousandShips
Copy link
Member

The setting was removed in:

And CI will fail until this reference is removed (CI will keep failing until #10979 is merged as the class reference links to a tutorial that doesn't exist yet)

Unsure if the whole block itself on "Area3D and static bodies" should be deleted, but removed the paragraph that references the now removed setting

@AThousandShips AThousandShips added this to the 4.5 milestone Jun 7, 2025
@AThousandShips AThousandShips requested a review from a team June 7, 2025 14:04
@AThousandShips AThousandShips added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:physics labels Jun 7, 2025
@skyace65
Copy link
Contributor

skyace65 commented Jun 7, 2025

@mihe This removal looks good. But does any of the remaining text need to be updated now that JPH::PhysicsSystem::SetSimCollideBodyVsBody is being used?

@AThousandShips
Copy link
Member Author

I think we can fix that in a separate PR, as the other PR needed to fix CI is pretty close to ready for merger it'd be good to get CI working

Copy link
Contributor

@mihe mihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if the whole block itself on "Area3D and static bodies" should be deleted, but removed the paragraph that references the now removed setting

It should, yes.

I have a couple of other changes lined up for this page that I was going to make a PR for next week, but you can remove the entire thing now if you want.

@skyace65 skyace65 merged commit 4af6a9a into godotengine:master Jun 7, 2025
1 check failed
@skyace65
Copy link
Contributor

skyace65 commented Jun 7, 2025

Thanks guys!

@AThousandShips AThousandShips deleted the fix_physics_refs branch June 7, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:physics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants