Skip to content

GDScript: Document abstract and variadic functions #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jun 15, 2025

@dalexeev dalexeev added this to the 4.5 milestone Jun 15, 2025
@dalexeev dalexeev added enhancement topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jun 15, 2025
@dalexeev dalexeev force-pushed the gds-abstract-and-variadic-funcs branch from 3f5a01a to 944cbfc Compare June 16, 2025 14:09
@geekley
Copy link

geekley commented Jun 17, 2025

Regarding @export_file_path, the 4.3->4.4 compatibility breakage (i.e. @export_file behavior changing from returning a path string to returning a uid string) needs to be documented, I believe this PR was intended to have it?

Reminder that there needs to be a mention in https://docs.godotengine.org/en/stable/tutorials/migrating/upgrading_to_godot_4.4.html

(sorry if saying it again was unnecessary)

@AThousandShips
Copy link
Member

There will be a dedicated PR for that, the file doesn't exist yet

@dalexeev
Copy link
Member Author

I believe this PR was intended to have it?

No, the subject of this PR is stated in the title. I just updated the lists of keywords, annotations, and global functions for syntax highlighting all at once.

@AThousandShips
Copy link
Member

AThousandShips commented Jun 17, 2025

My bad missed that that was cherry pick marked for 4.4 as well, so there needs to be a dedicated 4.4 PR adding this annotation to 4.4 as the rest of this is 4.5 specific (and a note in 4.4 upgrading) godotengine/godot#105414 gets cherry-picked

But regardless that shouldn't be changed until that PR gets cherry picked, if it is

@dalexeev dalexeev force-pushed the gds-abstract-and-variadic-funcs branch from 944cbfc to 9fee21d Compare June 22, 2025 17:23
@skyace65 skyace65 added the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Jun 22, 2025
@dalexeev dalexeev force-pushed the gds-abstract-and-variadic-funcs branch from 9fee21d to 7a7ac7d Compare June 24, 2025 07:25
@dalexeev dalexeev removed the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Jun 28, 2025
@dalexeev
Copy link
Member Author

@skyace65 skyace65 merged commit ba34190 into godotengine:master Jun 28, 2025
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants