-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update NavigationPathQueryObjects
to explain all (new) options
#11044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
.. tip:: | ||
|
||
For more advanced uses consider :ref:`doc_navigation_using_navigationpathqueryobjects` over NavigationAgent nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this tip is better suited to the bottom of this section.
It's not even begun talking about navigation agents and the page is already suggesting to rethink your choice
.. tip:: | ||
|
||
Path query parameters expose various options to improve pathfinding performance or lower memory consumptions. | ||
|
||
They cater to more advanced pathfinding needs that the high-level nodes can not always cover. | ||
|
||
See the respective option sections below. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't sound like a tip. It's describing exactly what these objects are for, I assume. Not sure what to do about that.
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
Is this only applicable to 4.5? |
I was sneaky and placed that note at the very bottom below the image :D |
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
0f1b7e5
to
b988f8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM style wise
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
tutorials/navigation/navigation_using_navigationpathqueryobjects.rst
Outdated
Show resolved
Hide resolved
Updates NavigationPathQueryObjects to explain all (new) options.
Updates
NavigationPathQueryObjects
to explain all (new) options (or flesh out existing)... available for
NavigationPathQueryParameters2D
/NavigationPathQueryParameters3D
.This is for Godot 4.5 only as some of the options are not available in older Godot versions or behave differently.