Skip to content

fix: [CDE-540]: Adding a check for user name and email during code clone operation. #3596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: [CDE-540]: Adding a check for user name and email during code clone operation. #3596

merged 2 commits into from
Dec 5, 2024

Conversation

dhruv-harness
Copy link
Contributor

Description

This PR introduces two changes

  1. Adding a check for user's name and email before cloning the code inside the gitspace container. This will non-block non-harness repos.
  2. Adding an explicit check for the media folder's path during VSCode web setup.

dhruv-harness and others added 2 commits December 5, 2024 13:12
@dhruv-harness @dhruv1397
fix: [CDE-540]: Adding check for media folder path during gitspace cr…
8324b16 
…eation. (#3100)

* fix: [CDE-540]: Adding check for media folder path during gitspace creation.

(cherry picked from commit 6f7e203)
@dhruv1397
fix: [CDE-540]: Adding a check for user name and email during code cl…
2daa6b8 
…one operation.
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dhruv-harness dhruv-harness changed the title fix: [CDE-540]: Adding check for media folder path during gitspace creation. fix: [CDE-540]: Adding a check for user name and email during code clone operation. Dec 5, 2024
@dhruv-harness dhruv-harness merged commit e92962b into release/3.0.0 Dec 5, 2024
2 of 3 checks passed
@dhruv-harness dhruv-harness deleted the CDE-540 branch December 5, 2024 08:20
bot2-harness pushed a commit that referenced this pull request Mar 26, 2025
@marko-gacesa
feat: [CODE-3405]: use case insensitive email matching for codeowners (…
5c05642 
…#3596)

* use case insensitive email matching for codeowners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n00bitax n00bitax n00bitax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhruv-harness @CLAassistant @n00bitax @dhruv1397