Skip to content

[Inference Providers] sambanova supports feature extraction #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 29, 2025
Merged

[Inference Providers] sambanova supports feature extraction #3037

merged 7 commits into from
Apr 29, 2025

Conversation

hanouticelina
Copy link
Contributor

@hanouticelina hanouticelina requested a review from Wauplin April 29, 2025 07:59
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

julien-c
julien-c approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hesitate to ping sambanova team for a quick review!

@hanouticelina hanouticelina requested a review from Wauplin April 29, 2025 15:27
@hanouticelina
Copy link
Contributor Author

I tested the PR both with sambanova and hf-inference, it works as expected ✅

Wauplin
Wauplin approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a re-implementation that doesn't seem needed otherwise good to merge.

EDIT: seems that ../tests/test_inference_providers.py::TestSambanovaProvider::test_prepare_payload_as_dict_feature_extraction is failing

@hanouticelina hanouticelina merged commit 8b54e42 into main Apr 29, 2025
23 of 25 checks passed
@hanouticelina hanouticelina deleted the add-new-tasks-for-sambanova branch April 29, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c approved these changes

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanouticelina @HuggingFaceDocBuilderDev @julien-c @Wauplin