Ubuntu 22.04 #1716

R3CK0 · 2025-02-25T20:32:53Z

Modified all tests to no longer require on indy-sdk. Started from where Adam left off. Please correct any changes where I am using wrong inputs/outputs

WadeBarnes · 2025-02-25T20:42:25Z

setup.py

+                        'indy_vdr==0.4.2', 
+                        'aries-askar==0.4.3', 
+                        'indy-credx==1.1.1'


This makes the indy-plenum deployment package dependent on client side components that are only used for tests.

WadeBarnes

General comment on the latest commit ...

It feels like there's duplication in the request parsing/conversion that could be consolidated.

WadeBarnes

@rhofirAtos, Your latest commit is missing DCO sign-off.

WadeBarnes · 2025-03-04T15:45:26Z

@rhofirAtos, Your latest commit is missing DCO sign-off.

lol, I see you noticed. Thanks

safio · 2025-03-07T18:37:48Z

@WadeBarnes I've addressed your comment regarding duplication in the request parsing/conversion by creating a helper function called convert_indy_vdr_request_to_plenum(). I'll include this in my next push.

WadeBarnes · 2025-03-10T13:36:07Z

Tests are still having issues with ioflo. It should be replaced as a test dependency so the tests can proceed and we get a better idea of where we're at with this PR.

WadeBarnes · 2025-03-12T14:51:21Z

setup.py

@@ -99,7 +99,7 @@ def run(self):
                        'base58',
                        # pinned because issue with fpm from v4.0.0
                        'importlib_metadata==3.10.1',
-                        # 'ioflo==2.0.2',
+                        'ioflo==2.0.3',


This will work, in that the expected version of ioflo will be installed, however ioflo is a dev/test dependency and not a runtime dependency. Therefore it should not be defined here. It should be defined in the tests_require section starting on line 30.

WadeBarnes · 2025-03-12T14:53:30Z

DCO sign-off was not included in the most recent commit. @rhofirAtos, please amend your latest commit with DCO sign-off.

WadeBarnes · 2025-03-14T12:16:18Z

.devcontainer/Dockerfile

    # Need to move libursa.so to parent dir
    && mv /usr/lib/ursa/* /usr/lib && rm -rf /usr/lib/ursa

 RUN pip3 install -U \
+    # Required by newer verion of python
+    ioflo==2.0.3 \


This should be unnecessary. ioflo should be installed as a dev dependency when plenum is installed in teh dev container by "postCreateCommand": "pip install .[tests]", in the devcontainer.json file.

WadeBarnes

@R3CK0 Please exclude the error logs from the commits.

Also the build is failing due to linting errors.

WadeBarnes · 2025-04-08T13:14:50Z

@R3CK0, Whatever's happened between this point https://github.com/hyperledger/indy-plenum/actions/runs/14197083841 and now is a step backwards. The tests where running and one slice was passing. In the current state the tests aren't able to even run.

WadeBarnes · 2025-04-08T13:44:11Z

That said, affected tests are running and passing locally.

WadeBarnes · 2025-04-08T14:48:01Z

I'm able to recrate the error locally by running the tests like the workflows do:

RUSTPYTHONASYNCIODEBUG=0 python3 runner.py --pytest "python3 -m pytest -l -vv" --dir "plenum" --output "test-result-plenum-1.txt" --test-only-slice "1/8"

Logs get output to test_list.txt

==================================== ERRORS ====================================
___ ERROR collecting plenum/test/plugin/demo_plugin/test_plugin_removing.py ____
ImportError while importing test module '/workspaces/indy-plenum/plenum/test/plugin/demo_plugin/test_plugin_removing.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
plenum/test/plugin/demo_plugin/test_plugin_removing.py:5: in <module>
    from plenum.test.freeze_ledgers.helper import sdk_send_freeze_ledgers
E   ImportError: cannot import name 'sdk_send_freeze_ledgers' from 'plenum.test.freeze_ledgers.helper' (/workspaces/indy-plenum/plenum/test/freeze_ledgers/helper.py)

WadeBarnes · 2025-04-08T15:37:09Z

Plenum slice tests are running again.

WadeBarnes · 2025-04-09T15:54:31Z

I'll have a look at the conflicts shortly.

R3CK0 · 2025-04-09T19:31:40Z

Removed the commit containing the error logs and the error identification script.

WadeBarnes · 2025-04-09T19:50:40Z

Removed the commit containing the error logs and the error identification script.

In doing so it appears you've also removed several commits I had made to the PR.

Signed-off-by: Adam Burdett <burdettadam@gmail.com> Signed-off-by: NicholasMassad <nicholasmassad@hotmail.com>

packages starting debugging process with tests Signed-off-by: Nicholas Massad <nicholasmassad@hotmail.com> Signed-off-by: NicholasMassad <nicholasmassad@hotmail.com>