Allow missingInterpolationHandler to be provided as t() option #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogelbrod
commented
Oct 18, 2018
| @@ -55,7 +55,7 @@ class Interpolator { | |||
| this.nestingRegexp = new RegExp(nestingRegexpStr, 'g'); | |||
| } | |||
|
|
|||
| interpolate(str, data, lng) { | |||
| interpolate(str, data, lng, options) { | |||
There was a problem hiding this comment.
Not entirely satisfied with the additional argument here, but I also don't wish to risk breaking backwards compatibility.
There was a problem hiding this comment.
agree - but like you said...the best option to keep it safe.
|
already late here....will merge this tomorrow and publish an updated version to npm |
|
Thank you for taking the time to provide this PR. Was merged and published to npm in i18next@11.10.0. And don’t forget to star this repo. Make a tweet or have a look at our https://locize.com -> there are many ways to help this project 🙏 |
|
Thanks for the quick responses, much appreciated! ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1117.