Skip to content

ResourceKey type should allow top level string value #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2019
Merged

ResourceKey type should allow top level string value #1267

merged 2 commits into from
Jun 17, 2019

Conversation

Kamahl19
Copy link
Contributor

ResourceKey can also be string like in this case

{
  en: {
    "logout": "Logout"
  }
}

@Kamahl19
Fix ResourceKey type
76eb2c6 
`ResourceKey` can also be string like in this case

```
{
  en: {
    "logout": "Logout"
  }
}
```
@coveralls
Copy link

coveralls commented Jun 16, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 89.013% when pulling 9e582bf on Kamahl19:patch-1 into 046f5f6 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin June 16, 2019 14:50
@rosskevin
Copy link
Collaborator

Thanks @Kamahl19, please add a test case to https://github.com/i18next/i18next/blob/master/test/typescript/init.test.ts to prevent regressions.

@Kamahl19
Copy link
Contributor Author

@rosskevin done

@rosskevin rosskevin changed the title Fix ResourceKey type ResourceKey type should allow top level string value Jun 17, 2019
@rosskevin rosskevin merged commit 406b108 into i18next:master Jun 17, 2019
@rosskevin
Copy link
Collaborator

@jamuhl this is a patch release

@jamuhl
Copy link
Member

jamuhl commented Jun 19, 2019

published in i18next@17.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kamahl19 @coveralls @rosskevin @jamuhl